Revert 'Bump MSRV to 1.68'

This effectively reverts 66cfc68dac
and adds some comments explaining that we're currently blocked by
Winit's MSRV policy + CI from being able to increase our
rust-version.

This is a frustrating conflict that I hope can be addressed by
updating Winit's CI system to allow different platforms to require
more recent versions of Rust (which notably isn't in conflict with
setting a conservative rust-version in Winit for supporting Debian
on Linux)

This re-instates building android-activity with cargo-ndk 2 because
building on Android with 1.64 requires a linker workaround that's
not implemented in newer version of cargo-ndk.

This also reinstates the clippy false-negative warning suppression
for unsafe blocks. Again it's frustrating that we can't have good
things because of how Winit wants to support Debian which shouldn't
be relevant for Android development.

Here is an upstream issue to discuss a potential solution for this:
https://github.com/rust-windowing/winit/issues/3000
This commit is contained in:
Robert Bragg
2023-08-04 15:37:05 +01:00
parent c0a9e20c5a
commit 1abb02c820
4 changed files with 22 additions and 4 deletions
+7 -3
View File
@@ -16,8 +16,9 @@ jobs:
strategy:
fail-fast: false
matrix:
# See top README for MSRV policy
rust_version: [1.68.0, stable]
# XXX: We are currently constrained by Winit's MSRV policy + CI system
# See Cargo.toml for details
rust_version: [1.64.0, stable]
steps:
- uses: actions/checkout@v3
@@ -34,7 +35,10 @@ jobs:
i686-linux-android
- name: Install cargo-ndk
run: cargo install cargo-ndk
# XXX: We have to use an old version of cargo-ndk that supports the
# libgcc linker workaround for rust < 1.68 because Winit's CI system
# currently requires this crate to be buildable with 1.64
run: cargo install cargo-ndk --version "^2"
- name: Setup Java
uses: actions/setup-java@v3