From 5869ff78beef94fea37239ffc87bdfd210b535b6 Mon Sep 17 00:00:00 2001 From: 2ro <17595647+2ro@users.noreply.github.com> Date: Thu, 2 Jul 2026 13:38:40 -0400 Subject: [PATCH] android: drop the notification enable-node action; re-enable macOS release CI The Android keep-alive notification's background job is the light Nostr-over-Nym payment listen ("Listening for payments"); the heavy integrated node is no longer STARTable from it (Goblin defaults to an external node). Only STOP is kept as a safety valve. Also re-enable the macOS release job (release: published) so a published release attaches a universal .app build on the native runner. --- .github/workflows/release.yml | 10 ++++++---- .../main/java/mw/gri/android/BackgroundService.java | 13 +++++++------ 2 files changed, 13 insertions(+), 10 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 40bb8625..28ad5853 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -8,10 +8,12 @@ name: Release on: - # macOS is DEFERRED until Linux/Windows/Android are polished — so this is - # manual-dispatch only for now (no auto-build on release publish). When macOS - # is back on the table, re-add `release: { types: [published] }` here and the - # macOS job will attach a universal build to each release automatically. + # macOS builds on its native runner automatically when a release is published + # (the macOS job has no dispatch-only gate). Linux/Windows stay dispatch-only — + # they are built locally and uploaded with the release; run the workflow by hand + # to (re)build those on runners against an existing tag. + release: + types: [published] workflow_dispatch: inputs: tag: diff --git a/android/app/src/main/java/mw/gri/android/BackgroundService.java b/android/app/src/main/java/mw/gri/android/BackgroundService.java index f58c0354..3cf557d1 100644 --- a/android/app/src/main/java/mw/gri/android/BackgroundService.java +++ b/android/app/src/main/java/mw/gri/android/BackgroundService.java @@ -74,12 +74,13 @@ public class BackgroundService extends Service { if (Build.VERSION.SDK_INT > 25) { startStopIntent.putExtra(EXTRA_NOTIFICATION_ID, NOTIFICATION_ID); } - if (canStart) { - startStopIntent.setAction(ACTION_START_NODE); - PendingIntent i = PendingIntent - .getBroadcast(BackgroundService.this, 1, startStopIntent, PendingIntent.FLAG_IMMUTABLE | PendingIntent.FLAG_ONE_SHOT); - mNotificationBuilder.addAction(R.drawable.ic_start, getStartText(), i); - } else if (canStop) { + // Goblin's background job is the light Nostr-over-Nym payment + // listen (the "Listening for payments" status); the heavy + // integrated node is never STARTED from this notification -- + // Goblin defaults to an external node, so the GRIM "Enable" + // action is removed. Only offer STOP as a safety valve if the + // node is somehow already running (started elsewhere). + if (canStop) { startStopIntent.setAction(ACTION_STOP_NODE); PendingIntent i = PendingIntent .getBroadcast(BackgroundService.this, 1, startStopIntent, PendingIntent.FLAG_IMMUTABLE | PendingIntent.FLAG_ONE_SHOT);