Consolidate and cleanup tx aggregation (#1332)

* Include commitments non-duplicate checks in aggregate
* Remove said check from the pool
* Block building now uses tx aggregation to reduce duplication

wallet/src/libtx/build.rs

@@ -293,7 +293,7 @@ mod test {
 			&keychain,
 		).unwrap();
 
-		tx.validate().unwrap();
+		tx.validate(false).unwrap();
 	}
 
 	#[test]
@@ -313,7 +313,7 @@ mod test {
 			&keychain,
 		).unwrap();
 
-		tx.validate().unwrap();
+		tx.validate(false).unwrap();
 	}
 
 	#[test]
@@ -327,6 +327,6 @@ mod test {
 			&keychain,
 		).unwrap();
 
-		tx.validate().unwrap();
+		tx.validate(false).unwrap();
 	}
 }

wallet/src/libtx/slate.rs

@@ -388,7 +388,7 @@ impl Slate {
 		final_tx.kernels[0].verify()?;
 
 		// confirm the overall transaction is valid (including the updated kernel)
-		let _ = final_tx.validate()?;
+		let _ = final_tx.validate(false)?;
 
 		self.tx = final_tx;
 		Ok(())

wallet/src/libwallet/internal/tx.rs

@@ -198,7 +198,7 @@ where
 
 	// finalize the burn transaction and send
 	let tx_burn = build::transaction(parts, &keychain)?;
-	tx_burn.validate()?;
+	tx_burn.validate(false)?;
 	Ok(tx_burn)
 }