From 06cb8bd969a0c3bcbb35450db8931c9389d93d08 Mon Sep 17 00:00:00 2001
From: Tommy Verrall <tommy@nymtech.net>
Date: Mon, 20 Oct 2025 21:30:58 +0200
Subject: [PATCH] fix all clippy messages

---
 common/http-api-client/src/lib.rs | 25 +++++++++++++++----------
 1 file changed, 15 insertions(+), 10 deletions(-)

diff --git a/common/http-api-client/src/lib.rs b/common/http-api-client/src/lib.rs
index 49d7263a03..ec1f524b50 100644
--- a/common/http-api-client/src/lib.rs
+++ b/common/http-api-client/src/lib.rs
@@ -591,14 +591,15 @@ impl ClientBuilder {
     pub fn from_network(
         network: &nym_network_defaults::NymNetworkDetails,
     ) -> Result<Self, HttpClientError> {
-        let urls = network
-            .nym_api_urls
-            .as_ref()
-            .ok_or_else(|| {
-                HttpClientError::GenericRequestFailure(
-                    "No API URLs configured in network details".to_string(),
-                )
-            })?
+        let api_urls =
+            network
+                .nym_api_urls
+                .as_ref()
+                .ok_or_else(|| HttpClientError::UrlParseFailure {
+                    source: url::ParseError::EmptyHost,
+                })?;
+
+        let urls = api_urls
             .iter()
             .map(|api_url| {
                 // Convert ApiUrl to our Url type with fronting support
@@ -611,8 +612,12 @@ impl ClientBuilder {
                         .iter()
                         .map(|host| format!("https://{}", host))
                         .collect();
-                    url = Url::new(api_url.url.clone(), Some(fronts))
-                        .map_err(|e| HttpClientError::GenericRequestFailure(e.to_string()))?;
+                    url = Url::new(api_url.url.clone(), Some(fronts)).map_err(|source| {
+                        HttpClientError::MalformedUrl {
+                            raw: api_url.url.clone(),
+                            source,
+                        }
+                    })?;
                 }
 
                 Ok(url)