From 39cb6f6ec09ee6a2f6dd9d29b006dd9240fe30ab Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jon=20H=C3=A4ggblad?= Date: Fri, 9 Dec 2022 15:04:47 +0100 Subject: [PATCH] network-requester: return error on socket close (#1876) * network-requester: return error when the socket closes * changelog: add note --- CHANGELOG.md | 5 +++++ service-providers/network-requester/src/core.rs | 2 +- service-providers/network-requester/src/error.rs | 3 +++ 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index c2926410d9..306b94c729 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,8 +8,13 @@ Post 1.0.0 release, the changelog format is based on [Keep a Changelog](https:// - validator-api: can recover from shutdown during DKG process ([#1872]) +### Fixed + +- network-requester: fix bug where websocket connection disconnect resulted in success error code + [#1872]: https://github.com/nymtech/nym/pull/1872 + ## [v1.1.2] ### Changed diff --git a/service-providers/network-requester/src/core.rs b/service-providers/network-requester/src/core.rs index e58bffaef0..70e0518e27 100644 --- a/service-providers/network-requester/src/core.rs +++ b/service-providers/network-requester/src/core.rs @@ -447,7 +447,7 @@ impl ServiceProvider { .await else { log::error!("The websocket stream has finished!"); - return Ok(()); + return Err(NetworkRequesterError::ConnectionClosed); }; let raw_message = received.message; diff --git a/service-providers/network-requester/src/error.rs b/service-providers/network-requester/src/error.rs index ab5390b19d..6e033305d0 100644 --- a/service-providers/network-requester/src/error.rs +++ b/service-providers/network-requester/src/error.rs @@ -7,4 +7,7 @@ pub enum NetworkRequesterError { #[error("Websocket error")] WebsocketConnectionError(#[from] WebsocketConnectionError), + + #[error("Websocket connection closed")] + ConnectionClosed, }