From 4cb9720758c320d3addee13ee873c15f9ab6da0f Mon Sep 17 00:00:00 2001 From: Dave Date: Thu, 3 Sep 2020 15:10:31 +0100 Subject: [PATCH] Ownership improvements --- .../simple-socks5/src/allowed_hosts.rs | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/service-providers/simple-socks5/src/allowed_hosts.rs b/service-providers/simple-socks5/src/allowed_hosts.rs index 8a406f8236..21cfd0f6b5 100644 --- a/service-providers/simple-socks5/src/allowed_hosts.rs +++ b/service-providers/simple-socks5/src/allowed_hosts.rs @@ -15,11 +15,10 @@ impl OutboundRequestFilter { } pub(crate) fn check(&mut self, host: &str) -> bool { - let hostname = host.to_string().clone(); - if self.allowed_hosts.contains(hostname.clone()) { + if self.allowed_hosts.contains(host) { true } else { - self.unknown_hosts.maybe_add(hostname); + self.unknown_hosts.maybe_add(host); false } } @@ -39,13 +38,13 @@ impl HostsStore { HostsStore { hosts } } - fn contains(&self, host: String) -> bool { - self.hosts.contains(&host) + fn contains(&self, host: &str) -> bool { + self.hosts.contains(&host.to_string()) } - fn maybe_add(&mut self, host: String) { - if !self.contains(host.clone()) { - self.hosts.push(host); + fn maybe_add(&mut self, host: &str) { + if !self.contains(&host) { + self.hosts.push(host.to_string()); } }