GRIN/nym
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Generate webpack favicons from PNG

Browse Source 
https://github.com/jantimon/favicons-webpack-plugin/issues/288 indicates that generating from an SVG sometimes freezes at 92%. This behaviour is seen on Windows wallet builds in CI.
This commit is contained in:
Mark Sinclair
2022-03-23 19:46:50 +00:00
parent 5eb2249ad5
commit 52ced9d3ad
3 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
assets/favicon/favicon.png
BIN
View File
Binary file not shown.
Side by Side

After

Width:  |  Height:  |  Size: 7.1 KiB

ts-packages/react-webpack-with-theme-example/README.md
+1 -1
View File
@@ -32,7 +32,7 @@ Shared Typescript config is in [tsconfig.json](./tsconfig.json), with specific p
Inherit config for Webpack 5 with additional tweaks including: Inherit config for Webpack 5 with additional tweaks including:
- favicon generation from [SVG favicon asset files](../../assets/favicon/favicon.svg) - favicon generation from [favicon asset files](../../assets/favicon/favicon.png)
- asset handling (svg, png, fonts, css, etc) - asset handling (svg, png, fonts, css, etc)
- minification - minification
ts-packages/webpack/webpack.common.js
+1 -1
View File
@@ -77,7 +77,7 @@ module.exports = (baseDir, htmlPath) => ({
}), }),
new WebpackFavicons({ new WebpackFavicons({
src: path.resolve(__dirname, '../../assets/favicon/favicon.svg'), // the asset directory is relative to THIS file src: path.resolve(__dirname, '../../assets/favicon/favicon.png'), // the asset directory is relative to THIS file
}), }),
new Dotenv(), new Dotenv(),