Fixed bunch of clippy warnings (#427)

common/socks5/ordered-buffer/src/buffer.rs

@@ -50,13 +50,10 @@ impl OrderedMessageBuffer {
 
         let mut contiguous_messages = Vec::new();
         let mut index = self.next_index;
-        loop {
-            if let Some(ordered_message) = self.messages.remove(&index) {
-                contiguous_messages.push(ordered_message);
-                index += 1;
-            } else {
-                break;
-            }
+
+        while let Some(ordered_message) = self.messages.remove(&index) {
+            contiguous_messages.push(ordered_message);
+            index += 1;
         }
 
         let high_water = index;

common/socks5/ordered-buffer/src/message.rs

@@ -27,7 +27,7 @@ impl OrderedMessage {
 
     /// Attempts to deserialize an `OrderedMessage` from bytes.
     pub fn try_from_bytes(data: Vec<u8>) -> Result<OrderedMessage, MessageError> {
-        if data.len() == 0 {
+        if data.is_empty() {
             return Err(MessageError::NoData);
         }
 

common/socks5/ordered-buffer/src/sender.rs

@@ -19,7 +19,7 @@ impl OrderedMessageSender {
             data: input.to_vec(),
             index: self.next_index,
         };
-        self.next_index = self.next_index + 1;
+        self.next_index += 1;
         message
     }
 }