backwards compatibility

This commit is contained in:
Jędrzej Stuczyński
2023-03-20 16:11:03 +00:00
parent f61ed48240
commit 6ffd211e51
10 changed files with 419 additions and 46 deletions
+1
View File
@@ -15,6 +15,7 @@ pub use client_core::config::Config as BaseConfig;
pub use client_core::config::MISSING_VALUE;
pub use client_core::config::{DebugConfig, GatewayEndpointConfig};
pub mod old_config;
mod template;
#[derive(Debug, Deserialize, PartialEq, Eq, Serialize, Clone, Copy)]
@@ -0,0 +1,60 @@
// Copyright 2023 - Nym Technologies SA <contact@nymtech.net>
// SPDX-License-Identifier: Apache-2.0
use crate::client::config::{Config, Socket};
use client_core::config::old_config::OldConfig as OldBaseConfig;
use nym_config::NymConfig;
use serde::{Deserialize, Serialize};
use std::path::PathBuf;
#[derive(Debug, Default, Deserialize, PartialEq, Serialize)]
#[serde(deny_unknown_fields)]
pub struct OldConfig {
#[serde(flatten)]
base: OldBaseConfig<OldConfig>,
socket: Socket,
}
impl NymConfig for OldConfig {
fn template() -> &'static str {
// not intended to be used
unimplemented!()
}
fn default_root_directory() -> PathBuf {
dirs::home_dir()
.expect("Failed to evaluate $HOME value")
.join(".nym")
.join("clients")
}
fn try_default_root_directory() -> Option<PathBuf> {
dirs::home_dir().map(|path| path.join(".nym").join("clients"))
}
fn root_directory(&self) -> PathBuf {
self.base.client.nym_root_directory.clone()
}
fn config_directory(&self) -> PathBuf {
self.root_directory()
.join(&self.base.client.id)
.join("config")
}
fn data_directory(&self) -> PathBuf {
self.root_directory()
.join(&self.base.client.id)
.join("data")
}
}
impl From<OldConfig> for Config {
fn from(value: OldConfig) -> Self {
Config {
base: value.base.into(),
socket: value.socket,
}
}
}
+7 -7
View File
@@ -110,15 +110,15 @@ host = '{{ socket.host }}'
[debug]
[[debug.traffic]]
average_packet_delay = '{{ debug.average_packet_delay }}'
message_sending_average_delay = '{{ debug.message_sending_average_delay }}'
[debug.traffic]
average_packet_delay = '{{ debug.traffic.average_packet_delay }}'
message_sending_average_delay = '{{ debug.traffic.message_sending_average_delay }}'
[[debug.acknowledgements]]
average_ack_delay = '{{ debug.average_ack_delay }}'
[debug.acknowledgements]
average_ack_delay = '{{ debug.acknowledgements.average_ack_delay }}'
[[debug.cover_traffic]]
loop_cover_traffic_average_delay = '{{ debug.loop_cover_traffic_average_delay }}'
[debug.cover_traffic]
loop_cover_traffic_average_delay = '{{ debug.cover_traffic.loop_cover_traffic_average_delay }}'
"#
}
+30 -7
View File
@@ -10,6 +10,7 @@ use crate::{
error::ClientError,
};
use crate::client::config::old_config::OldConfig;
use clap::Args;
use log::*;
use nym_bin_common::version_checker::is_minor_version_compatible;
@@ -97,16 +98,38 @@ fn version_check(cfg: &Config) -> bool {
}
}
fn load_config(id: &str) -> Result<Config, Box<dyn Error + Send + Sync>> {
// try to load the current config
match Config::load_from_file(id) {
Ok(config) => Ok(config),
Err(err) => {
warn!("Failed to load config for {id} - {err}...\nAttempting to use the old config template...");
// if this failed, try to use the old template
let old_config = match OldConfig::load_from_file(id) {
Ok(cfg) => {
info!("Managed to load config for {id} using old template");
cfg
}
Err(err) => {
error!("Failed to load config for {id} with the old template. Are you sure you have run `init` before? (Error was: {err})");
return Err(Box::new(ClientError::FailedToLoadConfig(id.to_string())));
}
};
info!("Updating the client config template...");
let updated: Config = old_config.into();
updated.save_to_file(None)?;
Ok(updated)
}
}
}
pub(crate) async fn execute(args: &Run) -> Result<(), Box<dyn Error + Send + Sync>> {
let id = &args.id;
let mut config = match Config::load_from_file(id) {
Ok(cfg) => cfg,
Err(err) => {
error!("Failed to load config for {}. Are you sure you have run `init` before? (Error was: {err})", id);
return Err(Box::new(ClientError::FailedToLoadConfig(id.to_string())));
}
};
let mut config = load_config(id)?;
let override_config_fields = OverrideConfig::from(args.clone());
config = override_config(config, override_config_fields);