From d158deba77e6458d0d48524d7eea799be4b5a4ff Mon Sep 17 00:00:00 2001 From: fmtabbara Date: Wed, 17 May 2023 10:07:25 +0100 Subject: [PATCH 1/4] add 'show all versions' options to gateways list --- .../Gateways/VersionDisplaySelector.tsx | 4 ++++ explorer/src/pages/Gateways/index.tsx | 16 ++++++++++++---- 2 files changed, 16 insertions(+), 4 deletions(-) diff --git a/explorer/src/components/Gateways/VersionDisplaySelector.tsx b/explorer/src/components/Gateways/VersionDisplaySelector.tsx index 927e46c026..e9be02b419 100644 --- a/explorer/src/components/Gateways/VersionDisplaySelector.tsx +++ b/explorer/src/components/Gateways/VersionDisplaySelector.tsx @@ -5,6 +5,7 @@ import { useIsMobile } from '../../hooks/useIsMobile'; export enum VersionSelectOptions { latestVersion = 'Latest versions', olderVersions = 'Older versions', + all = 'All', } export const VersionDisplaySelector = ({ selected, @@ -32,6 +33,9 @@ export const VersionDisplaySelector = ({ {VersionSelectOptions.olderVersions} + + {VersionSelectOptions.all} + ); diff --git a/explorer/src/pages/Gateways/index.tsx b/explorer/src/pages/Gateways/index.tsx index 77e9e04fa2..13c3eafc05 100644 --- a/explorer/src/pages/Gateways/index.tsx +++ b/explorer/src/pages/Gateways/index.tsx @@ -61,10 +61,18 @@ export const PageGateways: FCWithChildren = () => { return []; }, [gateways]); - const filteredByVersion = React.useMemo( - () => (versionFilter === VersionSelectOptions.latestVersion ? filterByLatestVersions : filterByOlderVersions), - [versionFilter, gateways], - ); + const filteredByVersion = React.useMemo(() => { + switch (versionFilter) { + case VersionSelectOptions.latestVersion: + return filterByLatestVersions; + case VersionSelectOptions.olderVersions: + return filterByOlderVersions; + case VersionSelectOptions.all: + return gateways?.data || []; + default: + return []; + } + }, [versionFilter, gateways]); React.useEffect(() => { if (searchTerm === '') { From 929b401f95cb62c03a959a666f7f53d4f39bbd1e Mon Sep 17 00:00:00 2001 From: fmtabbara Date: Wed, 17 May 2023 10:13:14 +0100 Subject: [PATCH 2/4] default to 'all version' --- .gitignore | 1 + explorer/src/pages/Gateways/index.tsx | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.gitignore b/.gitignore index 89ef98427f..c42461127a 100644 --- a/.gitignore +++ b/.gitignore @@ -8,6 +8,7 @@ .idea target .env +.env.dev /.vscode/settings.json validator/.vscode sample-configs/validator-config.toml diff --git a/explorer/src/pages/Gateways/index.tsx b/explorer/src/pages/Gateways/index.tsx index 13c3eafc05..028b90d8b8 100644 --- a/explorer/src/pages/Gateways/index.tsx +++ b/explorer/src/pages/Gateways/index.tsx @@ -25,7 +25,7 @@ export const PageGateways: FCWithChildren = () => { const [filteredGateways, setFilteredGateways] = React.useState([]); const [pageSize, setPageSize] = React.useState('50'); const [searchTerm, setSearchTerm] = React.useState(''); - const [versionFilter, setVersionFilter] = React.useState(VersionSelectOptions.latestVersion); + const [versionFilter, setVersionFilter] = React.useState(VersionSelectOptions.all); const theme = useTheme(); From 3ae5b59141931e1c8531e5505e750e7a93cc7972 Mon Sep 17 00:00:00 2001 From: Gala Date: Wed, 17 May 2023 11:27:49 +0200 Subject: [PATCH 3/4] small typo correction and service providers fix --- explorer/src/components/Universal-DataGrid.tsx | 2 +- explorer/src/typeDefs/explorer-api.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/explorer/src/components/Universal-DataGrid.tsx b/explorer/src/components/Universal-DataGrid.tsx index e545229a8c..df6c2a41e3 100644 --- a/explorer/src/components/Universal-DataGrid.tsx +++ b/explorer/src/components/Universal-DataGrid.tsx @@ -56,7 +56,7 @@ export const UniversalDataGrid: FCWithChildren = ({ rows, columns return ( Date: Wed, 17 May 2023 11:41:45 +0200 Subject: [PATCH 4/4] change where the change is applied --- explorer/src/components/Universal-DataGrid.tsx | 2 +- explorer/src/pages/ServiceProviders/index.tsx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/explorer/src/components/Universal-DataGrid.tsx b/explorer/src/components/Universal-DataGrid.tsx index df6c2a41e3..e545229a8c 100644 --- a/explorer/src/components/Universal-DataGrid.tsx +++ b/explorer/src/components/Universal-DataGrid.tsx @@ -56,7 +56,7 @@ export const UniversalDataGrid: FCWithChildren = ({ rows, columns return ( { pageSize={pageSize} childrenBefore={} /> - + ) : ( No service providers to display