moved nym-gateway-probe to monorepo and updated rust-edition to 2024 (#6094)

dont build netstack in CI

additional rust 2024 fixes

fixes

removed temp.rs

first round of cleanup

removed duplicated NS types

moved gateway probe to the monorepo

nym-node/src/cli/commands/debug/reset_providers_dbs.rs

@@ -3,8 +3,8 @@
 
 use crate::cli::helpers::ConfigArgs;
 use crate::config::upgrade_helpers::try_load_current_config;
-use crate::node::helpers::load_ed25519_identity_public_key;
 use crate::node::ServiceProvidersData;
+use crate::node::helpers::load_ed25519_identity_public_key;
 use nym_network_requester::{CustomGatewayDetails, GatewayDetails, GatewayRegistration};
 use std::fs;
 

nym-node/src/cli/commands/run/mod.rs

@@ -3,9 +3,9 @@
 
 use crate::config::upgrade_helpers::try_load_current_config;
 use crate::error::NymNodeError;
+use crate::node::NymNode;
 use crate::node::bonding_information::BondingInformation;
 use crate::node::mixnet::packet_forwarding::global::is_global_ip;
-use crate::node::NymNode;
 use std::fs;
 use std::net::IpAddr;
 use tracing::{debug, info, trace, warn};
@@ -28,9 +28,11 @@ fn check_public_ips(ips: &[IpAddr], local: bool) -> Result<(), NymNodeError> {
     if !suspicious_ip.is_empty() {
         warn!("\n##### WARNING #####");
         for ip in suspicious_ip {
-            warn!("The 'public' IP address you're trying to announce: {ip} may not be accessible to other clients.\
+            warn!(
+                "The 'public' IP address you're trying to announce: {ip} may not be accessible to other clients.\
             Please make sure this is what you intended to announce.\
-            You can ignore this warning if you're running setup on a local network ")
+            You can ignore this warning if you're running setup on a local network "
+            )
         }
         warn!("\n##### WARNING #####\n");
     }
@@ -49,7 +51,9 @@ pub(crate) async fn execute(mut args: Args) -> Result<(), NymNodeError> {
 
     if !accepted_operator_terms_and_conditions {
         warn!("you don't seem to have accepted the terms and conditions of a Nym node operator");
-        warn!("please familiarise yourself with <https://nymtech.net/terms-and-conditions/operators/v1.0.0> and run the binary with '--accept-operator-terms-and-conditions' flag if you agree with them");
+        warn!(
+            "please familiarise yourself with <https://nymtech.net/terms-and-conditions/operators/v1.0.0> and run the binary with '--accept-operator-terms-and-conditions' flag if you agree with them"
+        );
     }
 
     let config = if !config_path.exists() {
@@ -81,11 +85,15 @@ pub(crate) async fn execute(mut args: Args) -> Result<(), NymNodeError> {
     config.validate()?;
 
     if !config.modes.any_enabled() {
-        warn!("this node is going to run without mixnode or gateway support! consider providing `mode` value");
+        warn!(
+            "this node is going to run without mixnode or gateway support! consider providing `mode` value"
+        );
     }
 
     if config.modes.standalone_exit() {
-        warn!("this node is going to run in EXIT gateway mode only - it will not be able to accept client traffic and thus will NOT be eligible for any rewards. consider running it alongside `entry` (or `full-gateway`) mode")
+        warn!(
+            "this node is going to run in EXIT gateway mode only - it will not be able to accept client traffic and thus will NOT be eligible for any rewards. consider running it alongside `entry` (or `full-gateway`) mode"
+        )
     }
 
     if config.host.public_ips.is_empty() {

nym-node/src/cli/commands/sign.rs

@@ -44,7 +44,9 @@ fn print_signed_contract_msg(
     eprintln!(">>> attempting to sign {trimmed}");
 
     let Ok(decoded) = bs58::decode(trimmed).into_vec() else {
-        println!("it seems you have incorrectly copied the message to sign. Make sure you didn't accidentally skip any characters");
+        println!(
+            "it seems you have incorrectly copied the message to sign. Make sure you didn't accidentally skip any characters"
+        );
         return;
     };
 
@@ -53,7 +55,9 @@ fn print_signed_contract_msg(
     // we don't really care about what particular information is embedded inside of it,
     // we just want to know if user correctly copied the string, i.e. whether it's a valid bs58 encoded json
     if serde_json::from_slice::<serde_json::Value>(&decoded).is_err() {
-        println!("it seems you have incorrectly copied the message to sign. Make sure you didn't accidentally skip any characters");
+        println!(
+            "it seems you have incorrectly copied the message to sign. Make sure you didn't accidentally skip any characters"
+        );
         return;
     };
 

nym-node/src/cli/helpers.rs

@@ -6,8 +6,8 @@ use crate::config;
 use crate::config::default_config_filepath;
 use crate::env::vars::*;
 use celes::Country;
-use clap::builder::ArgPredicate;
 use clap::Args;
+use clap::builder::ArgPredicate;
 use std::net::{IpAddr, SocketAddr};
 use std::path::{Path, PathBuf};
 use url::Url;