From fbb675e8152f97aa7f4522ea57ff8a911487e28b Mon Sep 17 00:00:00 2001 From: Jedrzej Stuczynski Date: Thu, 12 Dec 2019 15:14:04 +0000 Subject: [PATCH] Future comment --- src/provider/storage/mod.rs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/provider/storage/mod.rs b/src/provider/storage/mod.rs index a78d6df50b..cead9e2db0 100644 --- a/src/provider/storage/mod.rs +++ b/src/provider/storage/mod.rs @@ -117,6 +117,8 @@ impl ClientStorage { } // TODO: THIS NEEDS A LOCKING MECHANISM!!! (or a db layer on top - basically 'ClientStorage' on steroids) + // TODO 2: This should only be called AFTER we sent the reply. Because if client's connection failed after sending request + // the messages would be deleted but he wouldn't have received them fn delete_file(path: PathBuf) { println!("Here {:?} will be deleted!", path); std::fs::remove_file(path); // another argument for db layer -> remove_file is NOT guaranteed to immediately get rid of the file