Fast check for duplicate tx in the pool (#1392)

pool/src/pool.rs

@@ -179,6 +179,12 @@ where
 
 		// Combine all the txs from the pool with any extra txs provided.
 		let mut txs = self.all_transactions();
+
+		// Quick check to see if we have seen this tx before.
+		if txs.contains(&entry.tx) {
+			return Err(PoolError::DuplicateTx);
+		}
+
 		txs.extend(extra_txs);
 
 		let agg_tx = if txs.is_empty() {

pool/src/types.rs

@@ -174,6 +174,8 @@ pub enum PoolError {
 	LowFeeTransaction(u64),
 	/// Attempt to add a duplicate output to the pool.
 	DuplicateCommitment,
+	/// Attempt to add a duplicate tx to the pool.
+	DuplicateTx,
 	/// Other kinds of error (not yet pulled out into meaningful errors).
 	Other(String),
 }