Replace panic with error for inserting duplicate pending ack (#4248)

2023-12-14 10:13:59 +01:00
parent 951f8e7a74
commit 723e30fb1d
1 changed files with 3 additions and 1 deletions
@@ -127,7 +127,9 @@ impl ActionController {
                .insert(frag_id, (Arc::new(pending_ack), None))
                .is_some()
            {
-                panic!("Tried to insert duplicate pending ack")
+                // This used to be a panic, however since we've seen this actually happen in the
+                // wild, let's not take the whole client (and possibly gateway) down because of it.
+                error!("Tried to insert duplicate pending ack! This should not be possible!")
            }
        }
    }