GRIN/nym
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(nym-api): correct reliability value conversions in performance simulation

Browse Source 
The old method simulation was incorrectly treating reliability values (0-1 fractions)
as percentages, causing all performance scores to be truncated to 0 when cast to u64.

Changes:
- Old method: multiply reliability by 100 before passing to Performance::from_percentage_value()
- New method: remove division by 100 since Performance::naive_try_from_f64() expects fractions
- Route analysis: multiply average reliability by 100 for percentage display

This ensures consistent handling where internal calculations use fractions (0-1)
while storage and API responses use percentages (0-100).
This commit is contained in:
durch
2025-06-24 19:04:09 +02:00
parent 8ad641f8f8
commit d67a968e76
2 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
nym-api/Cargo.toml
+1 -1
View File
@@ -4,7 +4,7 @@
[package]
name = "nym-api"
license = "GPL-3.0"
version = "1.1.64"
version = "1.1.65"
authors.workspace = true
edition = "2021"
rust-version.workspace = true
nym-api/src/epoch_operations/simulation.rs
+4 -5
View File
@@ -150,7 +150,7 @@ impl<'a> SimulationCoordinator<'a> {
for mix_reliability in mixnode_reliabilities {
performance_map.insert(
mix_reliability.mix_id(),
Performance::from_percentage_value(mix_reliability.value() as u64)
Performance::from_percentage_value((mix_reliability.value() * 100.0) as u64)
.unwrap_or_default(),
);
}
@@ -158,7 +158,7 @@ impl<'a> SimulationCoordinator<'a> {
for gateway_reliability in gateway_reliabilities {
performance_map.insert(
gateway_reliability.node_id(),
Performance::from_percentage_value(gateway_reliability.value() as u64)
Performance::from_percentage_value((gateway_reliability.value() * 100.0) as u64)
.unwrap_or_default(),
);
}
@@ -281,8 +281,7 @@ impl<'a> SimulationCoordinator<'a> {
performance_map.insert(
node_reliability.node_id,
Performance::naive_try_from_f64(node_reliability.reliability / 100.0)
.unwrap_or_default(),
Performance::naive_try_from_f64(node_reliability.reliability).unwrap_or_default(),
);
// Store sample counts for detailed performance records
@@ -330,7 +329,7 @@ impl<'a> SimulationCoordinator<'a> {
successful_routes,
failed_routes: total_routes - successful_routes,
average_route_reliability: if reliability_count > 0 {
Some(reliability_sum / reliability_count as f64)
Some(reliability_sum * 100.0 / reliability_count as f64)
} else {
None
},